Skip to content

[Alerting] Disable flapping per rule - UI changes #244165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[Alerting] Disable flapping per rule - UI changes #244165

wants to merge 18 commits into from
+116 −313

Conversation

@doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Nov 25, 2025 •
edited
Loading

Resolves #235132

Summary

This PR updates the rule form flapping settings to allow users to enable/disable flapping regardless of the global flapping settings.

Checklist

To verify

Global flapping enabled

  1. Create a new rule and set flapping settings. It'd be good to test enable and disabled flapping.
  2. Verify that when the rule runs your flapping settings are respected.
  3. Try updating the rule flapping settings and verify it's working as expected.

Global flapping disabled

  1. Verify that you can set flapping when global flapping is disabled.
  2. Verify that you can save the rule. It'd be good to test enable and disabled flapping in the settings.
  3. Verify that when the rule runs your flapping settings are respected.
  4. Try updating the rule flapping settings and verify it's working as expected.

Verify upgrading
Upgrade from main -> this branch
Run Kibana with yarn es snapshot --license trial -E path.data=../data

  1. Create a rule with custom flapping
  2. Stop Kibana and ES and switch to this branch
  3. Verify that the rule flapping settings are enabled and still working as expected.

doakalexi and others added 11 commits November 21, 2025 08:04
@doakalexi
Schema only changes
440557d
@doakalexi
Removing comment
dac6a89
@doakalexi
Fixing type check
3e286a3
@kibanamachine
Changes from node scripts/capture_oas_snapshot --include-path /api/st…
e91d306 
…atus --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update
@kibanamachine
Changes from make api-docs
a69e604
@doakalexi
Reverting some changes that aren't needed for schema only changes
2a76af1
@doakalexi
Merge branch 'alerting/235132' of github.com:doakalexi/kibana into al…
1bc10e7 
…erting/235132
@doakalexi
Removing other ui change
5ffe8f5
@doakalexi
Fixing so check
1631928
@doakalexi
Updating ui for enabling flapping
598de91
@doakalexi
Updating tests
64198ec
@doakalexi doakalexi changed the title Alerting/235132 UI [Alerting] Disable flapping per rule - UI changes Nov 25, 2025
@doakalexi doakalexi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.0 labels Nov 25, 2025
@doakalexi doakalexi mentioned this pull request Nov 26, 2025
Open
@doakalexi doakalexi marked this pull request as ready for review December 3, 2025 22:55
@doakalexi doakalexi requested a review from a team as a code owner December 3, 2025 22:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / Task Runner using aliases for alert indices should not use rule specific flapping settings if global flapping is disabled
  • [job] [logs] Jest Tests #6 / Task Runner using aliases for alert indices should not use rule specific flapping settings if global flapping is disabled
  • [job] [logs] Jest Tests #6 / Task Runner using data streams for alert indices should not use rule specific flapping settings if global flapping is disabled
  • [job] [logs] Jest Tests #6 / Task Runner using data streams for alert indices should not use rule specific flapping settings if global flapping is disabled

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerting-types 278 279 +1
alerting 827 828 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -841.0B
datasetQuality 505.4KB 504.5KB -841.0B
discover 1.3MB 1.3MB -841.0B
infra 1.1MB 1.1MB -841.0B
ml 5.6MB 5.6MB -841.0B
monitoring 631.5KB 630.6KB -841.0B
observability 1.7MB 1.7MB -834.0B
slo 992.2KB 991.4KB -841.0B
synthetics 1.0MB 1.0MB -841.0B
transform 624.6KB 623.8KB -841.0B
triggersActionsUi 1.5MB 1.5MB -824.0B
uptime 490.2KB 489.4KB -841.0B
total -9.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 107.0KB 107.1KB +18.0B
Unknown metric groups

API count

id before after diff
@kbn/alerting-types 282 283 +1
alerting 864 865 +1
total +2

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Alerting] Disable flapping per rule

3 participants

@doakalexi @elasticmachine @kibanamachine